Adding drop down to diff table#4354
Merged
Merged
Conversation
added 2 commits
August 5, 2022 12:12
elliette
reviewed
Aug 5, 2022
elliette
reviewed
Aug 5, 2022
elliette
reviewed
Aug 9, 2022
Member
|
Let's add a test case for the diff view with deferred units (it should be pretty similar to the test here: #4332) |
added 2 commits
August 9, 2022 10:53
elliette
reviewed
Aug 9, 2022
added 3 commits
August 9, 2022 14:39
elliette
approved these changes
Aug 9, 2022
| if (currentTab.key == AppSizeScreen.analysisTabKey && | ||
| isDeferredApp) | ||
| _buildAppUnitDropdown(), | ||
| if (isDeferredApp) _buildAppUnitDropdown(currentTab.key!), |
Member
There was a problem hiding this comment.
add some spacing here:
if (isDeferredApp) ...[
_buildAppUnitDropdown(currentTab.key!),
const SizedBox(width: defaultSpacing),
],
Contributor
Author
There was a problem hiding this comment.
Added spacing so that it only impacts the visuals when both drop downs are there.
added 2 commits
August 9, 2022 17:07
elliette
reviewed
Aug 10, 2022
| _diffCallGraphRoot.value = null; | ||
| _oldDiffCallGraph = null; | ||
| _newDiffCallGraph = null; | ||
| _isDeferredApp.value = false; |
Member
There was a problem hiding this comment.
Let's split this into a separate PR so we can add a test for it at the same time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For deferred apps, in the diff-table, the tab auto-opens to "Entire app" with a dropdown to switch between the entire app, the main unit, and the deferred units:
diffDropDown.mp4